[Xen-devel] [PATCH v2] x86/EFI: define and use EFI_DIR make variable, defaulting to /usr/lib64/efi

[Matt Wilson <msw@xxxxxxxxxx>]

After commit 25594:ad08cd8e7097, EFI Xen binaries were installed to
/efi instead of /usr/lib64/efi. This patch restores the previous
behviour established in commit 23645:638f31a30b6c.

Changes since v2:
 * Move the definition of EFI_DIR to config/x86_64.mk
 * Check to make sure that EFI_DIR is defined when installing files
   in xen/Makefile

Signed-off-by: Matt Wilson <msw@xxxxxxxxxx>
Reported-by: Olaf Hering <olaf@xxxxxxxxx>

diff -r 9950f2dc2ee6 -r 56aae8a6e7f3 config/x86_64.mk
--- a/config/x86_64.mk  Mon Jul 09 10:10:27 2012 +0100
+++ b/config/x86_64.mk  Mon Jul 16 23:37:16 2012 +0000
@@ -12,6 +12,8 @@ CFLAGS += -m64
 
 SunOS_LIBDIR = $(SunOS_LIBDIR_x86_64)
 
+EFI_DIR ?= /usr/lib64/efi
+
 # Use only if calling $(LD) directly.
 ifeq ($(XEN_OS),OpenBSD)
 LDFLAGS_DIRECT += -melf_x86_64_obsd
diff -r 9950f2dc2ee6 -r 56aae8a6e7f3 docs/misc/efi.markdown
--- a/docs/misc/efi.markdown    Mon Jul 09 10:10:27 2012 +0100
+++ b/docs/misc/efi.markdown    Mon Jul 16 23:37:16 2012 +0000
@@ -4,10 +4,12 @@ newer. Additionally, the binutils build 
 for the x86_64-pep emulation (i.e. `--enable-targets=x86_64-pep` or an option
 of equivalent effect should be passed to the configure script).
 
-Once built, `make install-xen` can place the resulting binary directly into
+Once built, `make install-xen` will place the resulting binary directly into
 the EFI boot partition, provided `EFI_VENDOR` is set in the environment (and
 `EFI_MOUNTPOINT` is overridden as needed, should the default of `/boot/efi` not
-match your system).
+match your system). The xen.efi binary will also be installed in
+`/usr/lib64/efi/`, unless `EFI_DIR` is set in the environment to 
+override the default.
 
 The binary itself will require a configuration file (names with the `.efi`
 extension of the binary's name replaced by `.cfg`, and - until an existing
diff -r 9950f2dc2ee6 -r 56aae8a6e7f3 xen/Makefile
--- a/xen/Makefile      Mon Jul 09 10:10:27 2012 +0100
+++ b/xen/Makefile      Mon Jul 16 23:37:16 2012 +0000
@@ -35,12 +35,12 @@ build install debug clean distclean csco
        ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION).gz 
$(DESTDIR)/boot/$(notdir $(TARGET))-$(XEN_VERSION).gz
        ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION).gz 
$(DESTDIR)/boot/$(notdir $(TARGET)).gz
        $(INSTALL_DATA) $(TARGET)-syms $(DESTDIR)/boot/$(notdir 
$(TARGET))-syms-$(XEN_FULLVERSION)
-       if [ -r $(TARGET).efi ]; then \
-               [ -d $(DESTDIR)$(LIBDIR)/efi ] || $(INSTALL_DIR) 
$(DESTDIR)$(LIBDIR)/efi; \
-               $(INSTALL_DATA) $(TARGET).efi $(DESTDIR)$(LIBDIR)/efi/$(notdir 
$(TARGET))-$(XEN_FULLVERSION).efi; \
-               ln -sf $(notdir $(TARGET))-$(XEN_FULLVERSION).efi 
$(DESTDIR)$(LIBDIR)/efi/$(notdir 
$(TARGET))-$(XEN_VERSION).$(XEN_SUBVERSION).efi; \
-               ln -sf $(notdir $(TARGET))-$(XEN_FULLVERSION).efi 
$(DESTDIR)$(LIBDIR)/efi/$(notdir $(TARGET))-$(XEN_VERSION).efi; \
-               ln -sf $(notdir $(TARGET))-$(XEN_FULLVERSION).efi 
$(DESTDIR)$(LIBDIR)/efi/$(notdir $(TARGET)).efi; \
+       if [ -r $(TARGET).efi -a -n '$(EFI_DIR)' ]; then \
+               [ -d $(DESTDIR)$(EFI_DIR) ] || $(INSTALL_DIR) 
$(DESTDIR)$(EFI_DIR); \
+               $(INSTALL_DATA) $(TARGET).efi $(DESTDIR)$(EFI_DIR)/$(notdir 
$(TARGET))-$(XEN_FULLVERSION).efi; \
+               ln -sf $(notdir $(TARGET))-$(XEN_FULLVERSION).efi 
$(DESTDIR)$(EFI_DIR)/$(notdir $(TARGET))-$(XEN_VERSION).$(XEN_SUBVERSION).efi; \
+               ln -sf $(notdir $(TARGET))-$(XEN_FULLVERSION).efi 
$(DESTDIR)$(EFI_DIR)/$(notdir $(TARGET))-$(XEN_VERSION).efi; \
+               ln -sf $(notdir $(TARGET))-$(XEN_FULLVERSION).efi 
$(DESTDIR)$(EFI_DIR)/$(notdir $(TARGET)).efi; \
                if [ -n '$(EFI_MOUNTPOINT)' -a -n '$(EFI_VENDOR)' ]; then \
                        $(INSTALL_DATA) $(TARGET).efi 
$(DESTDIR)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(notdir 
$(TARGET))-$(XEN_FULLVERSION).efi; \
                elif [ "$(DESTDIR)" = "$(patsubst $(shell cd $(XEN_ROOT) && 
pwd)/%,%,$(DESTDIR))" ]; then \

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel