Re: [Xen-devel] [PATCH] tools/vtpm: fix version.h error during parallel build

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("Re: [Xen-devel] [PATCH] tools/vtpm: fix version.h error 
during parallel build"):
> On Mon, Jul 23, Ian Jackson wrote:
> 
> > Olaf Hering writes ("[Xen-devel] [PATCH] tools/vtpm: fix version.h error 
> > during parallel build"):
> > > tools/vtpm: fix version.h error during parallel build
> > > 
> > > Generating the tpm_version.h is not make -j safe:
> > 
> > Thanks for tracking this down.  However, wouldn't it be possible to
> > fix this entirely in our Makefile, somehow ?  The patch to the
> > upstream Makefile risks getting conflicts in the future with changes
> > to the upstream code.
> 
> The build_sub rule in tools/vtpm/Makefile could be changed to 
> $(MAKE) -C $(VTPM_DIR) version && $(MAKE) -C $(VTPM_DIR) all-recursive; \
> 
> And the install rule in that Makefile perhaps to 
> $(MAKE) -C $(VTPM_DIR) install-recursive

Right, something like that.

> I will see how that works, the failure happens rarely.

I find that adding sleeps can help repro these kind of problems.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel