Re: [Xen-devel] [PATCH v10 18/19] libxl: convert libxl_device_vfb_add to an async operation

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v10 18/19] libxl: convert 
> libxl_device_vfb_add to an async operation"):
>> Split libxl_device_vfb_add into libxl__device_vfb_add (to be used
>> inside already running ao's), and make libxl_device_vfb_add a stub
>> to call libxl__device_vfb_add.
> 
> If I'm not mistaken this has the effect of newly waiting for vfbs to
> enter the correct state on xenstore.  Is that intentional ?

Yes, libxl waits for vfb to reach state 2 (InitWait), is that ok?

> If so it
> needs to be explained in the commit message.

Ok, I will rework on the commit message.

> Aside from that it looks plausible.
> 
> Thanks,
> Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel