Re: [Xen-devel] [PATCH v10 17/19] libxl: convert libxl_device_vkb_add to an async operation

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v10 17/19] libxl: convert 
> libxl_device_vkb_add to an async operation"):
>> Split libxl_device_vkb_add into libxl__device_vkb_add (to be used
>> inside already running ao's), and make libxl_device_vkb_add a stub to
>> call libxl__device_vkb_add.
> 
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> But if you are reposting for any reason you might like
> 
>> -    dcs->aodevs.size = d_config->num_disks;
>> +    if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_HVM && 
>> !d_config->num_vkbs) {
>> +        d_config->vkbs = libxl__zalloc(NOGC, sizeof(*d_config->vkbs));
> 
> to turn that into a use of GCNEW.  Or move
> 
>> +        libxl_device_vkb_init(&d_config->vkbs[0]);
>> +        d_config->num_vkbs = 1;
> 
> that assignment up and use GCNEW_ARRAY.  Up to you.

I can't use GCNEW because this is not allocated from the GC (I'm passing
NOGC to zalloc).

Thanks.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel