Re: [Xen-devel] [PATCH] libxl: fix vif.ifname when used with stub device model

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH] libxl: fix vif.ifname when used with stub device 
model"):
> libxl: fix vif.ifname when used with stub device model.
> 
> Currently the same libxl_device_nic is used to create both the HVM domain and
> its stub domain's NICs. This means that if a vifname is provided both the HVM
> domains PV NIC and the stub domains PV NIC will get the same name and the
> DM's NIC will fail to be attached.
> 
> Instead launder the libxl_device_nic to add the TAP_DEVICE_SUFFIX ("-emu").
> This is a bit of a misnomer, since the device is actually PV, but it is used 
> to
> "back" the emulated device in the stub domain and this naming scheme is
> consistent with the non-stub case and is known to work e.g. with our hotplug
> scripts.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

as far as it goes.

However I think this is related to Roger's:
   [PATCH v9 12/17] libxl: set correct nic type depending on the guest

Shouldn't the type field for the nics to be given to the stub dm be
forced to VIF ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel