Re: [Xen-devel] [PATCH v9 16/17] libxl: convert libxl_device_vkb_add to an async operation

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v9 16/17] libxl: convert libxl_device_vkb_add 
to an async operation"):
> Split libxl_device_vkb_add into libxl__device_vkb_add (to be used
> inside already running ao's), and make libxl_device_vkb_add a stub to
> call libxl__device_vkb_add.
...
> -    dcs->aodevs.size = d_config->num_disks;
> +    if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_HVM) {
> +        assert(!d_config->vkbs && !d_config->num_vkbs);

This is rather unfriendly - doesn't it amount to aborting on an
invalid domain configuration.  And I'm not sure I understand the
logic, which is new in your patch.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel