Re: [Xen-devel] [PATCH] xentop.c: Change curses painting behavior to avoid flicker

[slam <slam@xxxxxxxxxxx>]

On Tue, 17 Jul 2012 14:24:22 +0100
Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:

> Jason McCarver writes ("[PATCH] xentop.c: Change curses painting behavior to 
> avoid flicker"):
> > Currently, xentop calls clear() before drawing the screen and calling
> > refresh().  This causes the entire screen to be repainted from scratch
> > on each call to refresh().  It is inefficient and causes visible flicker
> > when using xentop.
> > 
> > This patch fixes this by calling erase() instead of clear() which overwrites
> > the current screen with blanks instead.  The screen is then drawn as usual
> > in the top() function and refresh() is called.  This method allows curses
> > to only repaint the characters that have changed since the last call
> > to refresh(), thus avoiding the flicker and sending fewer characters to
> > the terminal.
> > 
> > In the event the screen becomes corrupted, this patch accepts a CTRL-L
> > keystroke from the user which will call clear() and force a repaint of
> > the entire screen.
> > 
> > Signed-off-by: Jason McCarver <slam@xxxxxxxxxxx>
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> However, I think this needs to wait for Xen 4.3.  We are currently in
> the freeze for the 4.2 release.
> 
> Ian.

I apologize in advance for the newb questions.  Is there anything I need
to do to help this patch make it into 4.3?  Will I need to re-post it
to the list again at a later date, or is my first post of this
sufficient assuming the patch remains unchanged?

Jason

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel