Re: [Xen-devel] [PATCH 7/9] hotplug/NetBSD: check type of file to attach from params

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH 7/9] hotplug/NetBSD: check type of file to 
> attach from params"):
>> xend used to set the xenbus backend entry "type" to either "phy" or
>> "file", but now libxl sets it to "phy" for both file and block device.
>> We have to manually check for the type of the "param" filed in order
>> to detect if we are trying to attach a file or a block device.
> 
> This sounds and looks plausible but what if the type is something
> else ?

According to the checks we perform in libxl, it can't be anything else,
but it might be good to add an exit 1 if it's neither 'phy' nor 'file'.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel