Re: [Xen-devel] [PATCH 6/9] libxl: check backend state before setting it to "closing"

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH 6/9] libxl: check backend state before setting 
it to "closing""):
> Check backend state before unconditionally setting it to "closing"
> (5), since it might already be in "closed" (6).

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

> +        if (atoi(state) != XenbusStateClosed) {
> +            rc = libxl__xs_write_checked(gc, t, online_path, "0");
> +            if (rc) {
> +                LOG(ERROR, "unable to write to xenstore path %s", 
> online_path);
> +                goto out;
> +            }
> +            rc = libxl__xs_write_checked(gc, t, state_path, "5");

This business where we use XenbusStateClosed some of the time and "5",
"6", etc. the rest of the time, is incredibly confusing.  But now
probably isn't the time to open that can of worms.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel