[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v8 00/15] execute hotplug scripts from libxl

Ian Campbell wrote:
> On Tue, 2012-07-10 at 13:23 -0400, Roger Pau Monne wrote:
>>>> I'm working on making vfb/vkb async, once that is done I can take a look
>>>> on this,
>>> Cool. BTW is the other stuff ready? I guess it is waiting on IanJ to
>>> review again?
>> I've changed the series according to your comments, and I'm waiting for
>> IanJ review.
> BTW, an interesting enhancement might be to read
> the /local/domain/0/backend/vif/23/0/hotplug-error node and print it
> out. Currently with the "hotplug: vif: fail if a duplicate vifname is
> used" patch that I've just posted xl continues on despite the failure.
> With this series this is improved to:
>         # xl cr /etc/xen//debian-x86_32p-1
>         Parsing config from /etc/xen//debian-x86_32p-1
>         libxl: warning: libxl_exec.c:118:libxl_report_child_exitstatus: 
> /etc/xen/scripts/vif-bridge online [11939] exited with error status 1
> but with xm I get:
>         # xm cr /etc//xen/debian-HVM-1 
>         Using config file "/etc//xen/debian-HVM-1".
>         Error: Device 0 (vif) could not be connected. Cannot rename interface 
> vif20.0. An interface with name foo already exists.
> which is much friendlier.

Ok, so on error I will read "hotplug-error" and add it to the error
message. I think this is a Linux only thing, but it won't hurt to add it.

> Also it seems that despite xl reporting the error with you patches the
> domain is still running, although without networking... If a hotplug
> script fails can we abort and destroy the partially constructed domain
> instead?

Yes, I will change that and print and error and exit instead of just
printing a warning.

Thanks for the report.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.