[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] pygrub: avoid problems if guest files are large etc.

On Mon, 2012-07-02 at 00:47 +0100, M A Young wrote:
> On Tue, 26 Jun 2012, Matt Wilson wrote:
> > On Mon, Jun 25, 2012 at 02:34:02PM -0700, M A Young wrote:
> >> On Mon, 25 Jun 2012, Ian Campbell wrote:
> >>
> >>> BTW, what is the status of that patch?
> >>
> >> I am attaching version 4 of my patch. It moves handling of the kernel and
> >> ramdisk into a function along the lines of Miroslav Rezanina's patch
> >> http://lists.xen.org/archives/html/xen-devel/2012-05/msg01499.html
> >> It adds checking for problems opening the kernel or ramdisk files and
> >> checks they exist in the not_really mode as discussed in this thread.
> >>
> >> I still think it is a good idea to remove the temporary copies of the
> >> kernel and ramdisk if there are problems copying them because I am not
> >> convinced the calling process always removes them and it might be
> >> presented with truncated files if copying the files filled the filespace.
> Here is version 5 of my patch, modified following Matt Wilson's 
> suggestions, standardizing the indentations, moving some of the clean up 
> out of the loop, and reporting the actual error.

Looks good to me. 

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

>       Michael Young

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.