Re: [Xen-devel] [PATCH 1/3] libxl:refactor stdvga option support v2

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

> diff -r 592d15bd4d5e tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c  Fri May 18 16:19:21 2012 +0100
> +++ b/tools/libxl/xl_cmdimpl.c  Wed Jun 27 20:06:39 2012 +0800
> @@ -1256,7 +1256,10 @@ skip_vfb:
>  #undef parse_extra_args
> 
>      if (c_info->type == LIBXL_DOMAIN_TYPE_HVM) {
> -        xlu_cfg_get_defbool(config, "stdvga", &b_info->u.hvm.stdvga, 0);
> +        if (!xlu_cfg_get_long(config, "stdvga", &l, 0))
> +            if (l)
> +                b_info->u.hvm.vga.kind = LIBXL_VGA_INTERFACE_TYPE_STD;

I think this needs to be:
          if (!xlu_cfg_get_long(config, "stdvga", &l, 0))
                b_info->u.hvm.vga.kind = l ? \ 
                                         LIBXL_VGA_INTERFACE_TYPE_STD : \
                                         LIBXL_VGA_INTERFACE_TYPE_CIRRUS;

so that both "stdvga=0" and "stdvga=1" result in what the user asked for
without relying on the libxl default remaining CIRRUS.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel