Re: [Xen-devel] [PATCH 31/38] arm: gic.lock can be taken in interrupt context, so lock appropriately.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-06-26 at 12:41 +0100, Stefano Stabellini wrote:
> On Tue, 26 Jun 2012, Ian Campbell wrote:
> > > > @@ -601,7 +601,7 @@ static void maintenance_interrupt(int irq, void 
> > > > *dev_id, struct cpu_user_regs *r
> > > >          } else {
> > > >              gic_inject_irq_stop();
> > > >          }
> > > > -        spin_unlock(&gic.lock);
> > > > +        spin_unlock_irq(&gic.lock);
> > > >  
> > > >          spin_lock(&current->arch.vgic.lock);
> > >                ^
> > > shouldn't you change this into spin_lock_irq too?
> > 
> > 
> > If so then that should be in "arm: use interrupt safe spin locks in
> > vgic_vcpu_inject_irq" rather than here?
> > 
> > I think you've reworked this stuff a bit in one of your follow up series
> > -- is it worth me changing this here or do you handle it / make it
> > irrelevant?
>  
> No, I am not, I am only removing everything related to
> events_maintenance. I think it is worth fixing it in one of your patches
> or in a follow up patch.

OK, I'll do it in another patch.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel