Re: [Xen-devel] [PATCH] x86/mm: fix mod_l1_entry() return value when encountering r/o MMIO page

[Keir Fraser <keir@xxxxxxx>]

On 20/06/2012 16:18, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> While putting together the workaround announced in
> http://lists.xen.org/archives/html/xen-devel/2012-06/msg00709.html, I
> found that mod_l1_entry(), upon encountering a set bit in
> mmio_ro_ranges, would return 1 instead of 0 (the removal of the write
> permission is supposed to be entirely transparent to the caller, even
> more so to the calling guest).
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Keir Fraser <keir@xxxxxxx>

> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -1875,6 +1875,7 @@ static int mod_l1_entry(l1_pgentry_t *pl
>              break;
>          case 1:
>              l1e_remove_flags(nl1e, _PAGE_RW);
> +            rc = 0;
>              break;
>          }
>          if ( page )
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel