Re: [Xen-devel] [PATCH] libxl: document the memory ownership of some functions

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Dario Faggioli writes ("Re: [PATCH] libxl: document the memory ownership of 
some functions"):
> On Fri, 2012-06-15 at 15:11 +0100, Ian Jackson wrote:
> > Perhaps it would be worth writing this comment once near the top, eg:
> > 
> >  /* These functions each return (on success) an array of elements,
> >   * and the length via the int* out parameter.  These arrays and
> >   * their contents come from malloc, and must be freed with the
> >   * corresponding libxl_THING_list_free function.
> >   */
> > 
> > And perhaps change  int *nb_domain  etc. to  int *nb_domain_out.
> 
> I like this, and I'm fine with going for this and respending. Just to be
> sure, I'd need to gather all those functions together, moving them from
> their current positions in the header... Would that be fine?

Moving the functions is fine if it seems like the new order is
reasonable.  I haven't checked...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel