Re: [Xen-devel] [PATCH v6] libxl: introduce LIBXL_DOMAIN_TYPE_INVALID

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-06-06 at 14:42 +0100, Dario Faggioli wrote:
> To avoid recent gcc complaining about:
> libxl.c: In function 'libxl_primary_console_exec':
> libxl.c:1233:9: error: case value '4294967295' not in enumerated type 
> 'libxl_domain_type' [-Werror=switch]
> 
> Also:
>  - have all the call sites of libxl__domain_type() return with error in
>    case the function returns LIBXL_DOMAIN_TYPE_INVALID;
>  - adjust all other code segments where -Wswitch makes would claim that
>    LIBXL_DOMAIN_TYPE_INVALID is not handled by adding a "default: abort();"
>    clause.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> @@ -310,6 +311,7 @@ libxl_domain_build_info = Struct("domain
>                                        # Use host's E820 for PCI passthrough.
>                                        ("e820_host", libxl_defbool),
>                                        ])),
> +                 ("invalid", Struct(None, [])),
>                   ], keyvar_init_val = "-1")),

This -1 should => LIBXL_DOMAIN_TYPE_INVALID, but I'll just make that
change as I commit it, if that's ok with you...

>      ], dir=DIR_IN
>  )



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel