[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/5] xen: Add headers to include/Makefile

>>> On 31.05.12 at 17:07, Jean Guyader <jean.guyader@xxxxxxxxxx> wrote:

>   Add stdlib.h for size_t
>   Add string.h for memcpy
>   Add sys/types.h for ssize_t
> Signed-off-by: Jean Guyader <jean.guyader@xxxxxxxxxx>

Sorry, I don't think this is correct: What you're modifying is the
rule to validate public headers, and public headers should never
include any of the three above - the only headers consuming
defined symbols of which is half-way acceptable are those that
exclusively deal with compiler properties (stddef.h, stdint.h,
stdbool.h, stdarg.h, and maybe inttypes.h).

Plus I don't see how public headers would legitimately and
portably (keep 32-on-64 in mind!) use any of the three symbols
mentioned above.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.