Re: [Xen-devel] [PATCH 01/15] libxc: xc_domain_restore, make toolstack_restore const-correct

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-05-31 at 10:55 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH 01/15] libxc: xc_domain_restore, 
> make toolstack_restore const-correct"):
> > On Wed, 2012-05-30 at 17:16 +0100, Ian Jackson wrote:
> > > Also provide typedefs for the nontrivial function callback types.
> > 
> > Are there any other uses of these type other than the one of each
> > inlined in the structs?
> 
> There is one, later in my patch series, in libxl.

Ah, I had a look up to ptch 5 (the originally posted set) but didn't
spot it, sorry.

> > If not then I'm not sure this makes things clearer -- you now have to
> > look at both the callback struct and then go find the corresponding
> > typedef.
> 
> I'm not particularly bothered about this and could write the type out
> again in its other location in libxl_internal.h.  The compiler will
> check it after all.
> 
> Let me know what you think best.

I prefer to write it out. Especially since the docs (such as they are)
are in the struct too.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel