Re: [Xen-devel] [PATCH 02/15] libxl: domain save: rename variables etc.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 02/15] libxl: domain save: rename 
variables etc."):
> 
> > @@ -921,71 +913,72 @@ int libxl__domain_suspend_common(libxl__gc *gc, 
> > uint32_t domid, int fd,
...
> > +    xcflags = (live) ? XCFLAGS_LIVE : 0
> >            | (debug) ? XCFLAGS_DEBUG : 0
> >            | (hvm) ? XCFLAGS_HVM : 0;
...
> > +    dss->xcflags = xcflags;
...
> > +            xcflags |= XCFLAGS_CHECKPOINT_COMPRESS;
> 
> You now do this after the "dss->xcflags = xcflags" (since you moved that
> block up), won't that mean you loose it?

Yes.

> (xcflags gets used again below in the call to xc_domain_save, but I
> guess that'll go away during asyncification).

I should have abolished the local variable entirely.  Given that I'm
renaming the variable I might as well change all the references to use
dss->xcflags which eliminates the possibility to make this kind of
mistake.

So I will do that.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel