Re: [Xen-devel] [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems

["H. Peter Anvin" <hpa@xxxxxxxxx>]

On 05/30/2012 03:33 PM, Konrad Rzeszutek Wilk wrote:
> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> index 75f33b2..e74df95 100644
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -1116,7 +1116,10 @@ static const struct pv_cpu_ops xen_cpu_ops __initconst 
> = {
>       .wbinvd = native_wbinvd,
>  
>       .read_msr = native_read_msr_safe,
> +     .rdmsr_regs = native_rdmsr_safe_regs,
>       .write_msr = xen_write_msr_safe,
> +     .wrmsr_regs = native_wrmsr_safe_regs,
> +
>       .read_tsc = native_read_tsc,
>       .read_pmc = native_read_pmc,
>  

Okay, tell me again:

why do we have these hooks again?  Can we please weed out paravirt
methods that have no users?

        -hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel