Re: [Xen-devel] [xen-unstable test] 12988: regressions - FAIL

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-05-30 at 10:44 +0100, Ian Campbell wrote:
> It seems likely that this is related to:
>         changeset:   25409:894493e84fe7
>         user:        Ian Campbell <ian.campbell@xxxxxxxxxx>
>         date:        Tue May 29 16:44:06 2012 +0100
>         files:       tools/libxl/Makefile tools/libxl/libxl.h 
> tools/libxl/libxl_internal.h tools/libxl/libxl_paths.c tools/libxl/xl.c 
> tools/libxl/xl.h
>         description:
>         libxl: remove lockdir and config dir from the API
>         
>         These are only used by xl.
>         
>         Rename _libxl_paths.h -> _paths.h, these are not actually "libxl" 
> paths but
>         rather are part of the Xen build time configuration. It is fine for 
> xl to also
>         consume them.
>         
> But I can't see anything wrong there [...]

Yes, I can. I reckon this is the fix.

8<-----------

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1338371140 -3600
# Node ID 017b76385a4c77ec3fb9dd791b6c7d19d0be401c
# Parent  2fef99911c6f179297b47e24246810d92d08d348
xl: xl.h depends on geenrated file _paths.h

Fixes build error.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 2fef99911c6f -r 017b76385a4c tools/libxl/Makefile
--- a/tools/libxl/Makefile      Wed May 30 10:33:55 2012 +0100
+++ b/tools/libxl/Makefile      Wed May 30 10:45:40 2012 +0100
@@ -120,6 +120,7 @@ libxl.h: _libxl_types.h
 libxl_json.h: _libxl_types_json.h
 libxl_internal.h: _libxl_types_internal.h _paths.h
 libxl_internal_json.h: _libxl_types_internal_json.h
+xl.h: _paths.h
 
 $(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS): libxl.h
 $(LIBXL_OBJS): libxl_internal.h




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel