Re: [Xen-devel] [PATCH v7 0/8] arm: compile tools

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-05-29 at 16:56 +0100, Stefano Stabellini wrote:
> On Tue, 29 May 2012, Stefano Stabellini wrote:
> > Hi all,
> > this patch series allows tools/ to compile on ARM, mostly providing an
> > empty implementation for all the arch specific functions that are needed.
> > 
> > All the patches of this series have been previously acked.
> 
> I am proposing this series for 4.2, not only because it has been acked
> since the beginning of March
> (http://marc.info/?l=xen-devel&m=133070513015066) and it doesn't contain
> any functional changes since then, but also because the X86 changes are
> limited to code motion and related Makefile.
> 
> In particular:
> 
> - patch #1
> the big x86 change is just a rename of xc_hvm_build.c to xc_hvm_build_x86.c;
> 
> - patch #4
> moves libxl_cpuid_policy_list_gen_json from libxl_json.c to
> libxl_cpuid.c;
> 
> - patch #6
> moves 10 lines from libxl_create.c to libxl_x86.c;

... and s/ctx/gc->owner (which is fine, AFAICT, but useful to mention).

> - patch #7
> move e820_names, e820_sanitize, libxl__e820_alloc from libxl_pci.c to
> libxl_x86.c.

I checked all these and they are indeed code motion (other than the nit
above).

I build tested x86 and arm and have pushed.

Thanks!

> 
> 
> 
> 
> 
> 
> > 
> > Changes in v7:
> > 
> > - rebase on "x86_64: Record entry vector for double faults.";
> > 
> > - split the last patch in three patches to make it easier to read and
> > find all the code motions (I kept the acked-by on all the patches
> > because there are no changes except the split).
> > 
> > 
> > Changes in v6:
> > 
> > - rebase on 33659563f589 (this is a mercurial id).
> > 
> > 
> > Changes in v5:
> > 
> > - libxc: return -1 and set errno on error;
> > 
> > - add few missing emacs runes in new files.
> > 
> > 
> > Changes in v4:
> > 
> > - rebased on 55a36564fb4f85722c67f16fe508f3ecbd204549;
> > 
> > - minor compile fixes.
> > 
> > 
> > 
> > Changes in v3:
> > 
> > - move libxl_cpuid_policy_list_gen_json to libxl_(no)cpuid.c;
> > 
> > - rename xc_hvm_build.c to xc_hvm_build_x86.c;
> > 
> > - remove xc_nohvm, introduce xc_hvm_build_arm.c instead;
> > 
> > - remove "libxl: do not allocate e820 for non x86 guests.";
> > 
> > - introduce libxl__arch_domain_create.
> > 
> > 
> > 
> > Changes in v2:
> > 
> > - rebased on a22587ae517170a7755d3a88611ae0e2d5bb555e;
> > 
> > - dropped "arm: arch_dump_shared_mem_info as a no-op" that is already in
> > xen-unstable;
> > 
> > - define xen_callback_t as uint64_t;
> > 
> > - define guest_word_t as uint64_t.
> > 
> > 
> > 
> > Stefano Stabellini (8):
> >       arm: compile libxenguest
> >       arm: compile memshr
> >       arm: compile xentrace
> >       arm: compile libxl
> >       libxl: Introduce libxl__arch_domain_create
> >       libxl: Introduce libxl__arch_domain_create (x86 version)
> >       libxl: move e820_names, e820_sanitize, libxl__e820_alloc to 
> > libxl_x86.c
> >       libxl: make libxl__e820_alloc a static function
> > 
> >  tools/libxc/Makefile           |   12 +-
> >  tools/libxc/xc_dom_arm.c       |   50 +++++
> >  tools/libxc/xc_hvm_build.c     |  472 
> > ----------------------------------------
> >  tools/libxc/xc_hvm_build_arm.c |   49 ++++
> >  tools/libxc/xc_hvm_build_x86.c |  472 
> > ++++++++++++++++++++++++++++++++++++++++
> >  tools/libxc/xc_nomigrate.c     |   54 +++++
> >  tools/libxl/Makefile           |    5 +-
> >  tools/libxl/libxl_arch.h       |   22 ++
> >  tools/libxl/libxl_cpuid.c      |   60 +++++
> >  tools/libxl/libxl_create.c     |   12 +-
> >  tools/libxl/libxl_internal.h   |    2 -
> >  tools/libxl/libxl_json.c       |   60 -----
> >  tools/libxl/libxl_noarch.c     |    8 +
> >  tools/libxl/libxl_nocpuid.c    |    8 +-
> >  tools/libxl/libxl_pci.c        |  242 --------------------
> >  tools/libxl/libxl_x86.c        |  262 ++++++++++++++++++++++
> >  tools/memshr/bidir-hash.c      |   31 +++
> >  tools/xentrace/xenctx.c        |   12 +
> >  18 files changed, 1041 insertions(+), 792 deletions(-)
> > 
> > 
> > Cheers,
> > 
> > Stefano
> > 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel