Re: [Xen-devel] [PATCH 11/13] libxl: set nic type to VIF by default

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-05-29 at 16:02 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH 11/13] libxl: set nic type to 
> VIF by default"):
> > On Tue, 2012-05-29 at 15:40 +0100, Ian Jackson wrote:
> ...
> > > I'm a bit confused about all this, I confess.  What does xend do ?
> > > 
> > > ATM it seems that this change would mean that a guest config file
> > > specified in the most obvious way wouldn't get an emulated nic at
> > > all.  That can't be right, can it ?
> > 
> > It's confusingly named.
> > 
> > IOEMU -> emulated only on HVM, meaningless on PV.
> > VIF   -> both emulated and PV (on HVM) or just PV (on PV)
> > 
> > So a default of "VIF" is what you normally want.
> 
> Oh!
> 
> Perhaps we could rename the enum values (and disrupt everyone's
> patches) to fix this before we call the API stable.

As a "Nice To Have", perhaps. The stable API rules we have set don't
preclude us changing them later, we just have to provide a suitable
compat define if LIBXL_API_VERSION is set to a relevant value.

What are some better names? IOEMU, VIF and HYBRID? Or DUAL?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel