Re: [Xen-devel] [PATCH] make pygrub cope better with big files in guest

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

M A Young writes ("Re: [Xen-devel] [PATCH] make pygrub cope better with big 
files in guest"):
> I am attaching the third version of this patch. The datafile object 
> doesn't have an explicit close so this patch uses del to clean it. I was 
> also using unlink incorrectly which is now fixed.

Why does pygrub need to unlink the output files on error ?  Shouldn't
pygrub's caller do that ?  libxl does.

Also the two bits of code which read the kernel and ramdisk are now
much larger and very similar to each other.  Couldn't this be
refactored to have less duplication ?

Python even supports local functions...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel