Re: [Xen-devel] [PATCH 1/3] xen: Add instruction length parameter in function hvm_inject_exception

[Aravindh Puthiyaparambil <aravindh@xxxxxxxxxxxx>]

On Fri, May 25, 2012 at 1:53 AM, Keir Fraser <keir@xxxxxxx> wrote:
> On 24/05/2012 20:06, "Xudong Hao" <xudong.hao@xxxxxxxxx> wrote:
>
>> VMX exception: Pass the instruction length field down to exception emulation,
>> by changing hypercall parameter and adding a parameter in fucntion
>> hvm_inject_exception(), so that exception emulation can set correct
>> instruction length.
>>
>> Signed-off-by: Xudong Hao <xudong.hao@xxxxxxxxx>
>> Signed-off-by: Xiantao Zhang <xiantao.zhang@xxxxxxxxx>
>
> I don't like adding yet another parameter for all callers, especially as we
> should also be passing down the event type (sw interrupt, hw exception, ...)
> and that would bloat the parameter list further.
>
> I attach a cleanup patch which packs everything into a new struct and
> renames hvm_inject_exception to hvm_inject_trap. I then define a couple of
> wrappers around that function for existing callers, so that their parameter
> lists actually *shrink*.
>
> Let me know what you think. If it looks acceptable I can check it in and we
> can build on top of this restructuring. The aim being to keep
> hvm/vmx_inject_trap dumb, and push down the knowledge from the callers into
> it.

So I take it that with just this patch injecting of software
interrupts will not work and I should hold off on testing that out.
What is the plan for injecting software interrupts? Add another libxc
API for that?

Thanks,
Aravindh

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel