Re: [Xen-devel] [PATCH v3 05/11] arm: shared_info page allocation and mapping

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-05-25 at 14:54 +0100, Stefano Stabellini wrote:
> On Wed, 14 Mar 2012, Ian Campbell wrote:
> > On Fri, 2012-03-02 at 14:27 +0000, Stefano Stabellini wrote:
> > > @@ -118,7 +118,12 @@ static int create_p2m_entries(struct domain *d,
> > >          }
> > >          /* else: third already valid */
> > >  
> > > -        BUG_ON(third[third_table_offset(addr)].p2m.valid);
> > > +        if ( third[third_table_offset(addr)].p2m.valid )
> > > +        {
> > > +            /* p2m entry already present */
> > > +            free_domheap_page(
> > > +                    
> > > mfn_to_page(third[third_table_offset(addr)].p2m.base));
> > > +        }
> > 
> > If there was already an entry here don't we need to do something with
> > whatever it points to? Either free it or deref or something?
> 
> We are already doing something: we are free'ing the old page. There is
> no need to do anything to the p2m entry because it is going to be
> overwritten by the new one few lines below.

I honestly have no idea WTF I was talking about...

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel