[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] x86_64: Fix double fault stack setup

On 24/05/12 19:04, Keir Fraser wrote:
> On 24/05/2012 16:28, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx> wrote:
>> Ah yes - how silly of me.  I misread the manual when checking that fact,
>> but this was an INT 08 experiment.  I really should have checked with a
>> ud2 as well.
>> That is a bit awkward.
>> Do we actually care about this error from an INT 08?  I suppose we could
>> check under rip for 0xcd 0x08, but then the same argument would apply to
>> all other exceptions which may push an error onto the stack.
>> Do we care however that entry_vector is not being set correctly?  I cant
>> see anything on the current codepath which uses it, but it doesn't
>> preclude someone adding code in the future.
> It would be a simple one-line patch and make that entry point consistent
> with all other exception-handling entry points. So I'm in favour of it.
>  -- Keir

Ok - attached.

Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com

Attachment: x86_64-double-fault-entry-vector.patch
Description: Text Data

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.