Re: [Xen-devel] [PATCH] x86: fix nested HVM initialization

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.05.12 at 14:44, Christoph Egger <Christoph.Egger@xxxxxxx> wrote:
> On 05/24/12 14:14, Jan Beulich wrote:
> 
>> - no need for calling nestedhvm_setup() explicitly (can be a normal
>>   init-call, and can be __init)
>> - calling _xmalloc() for multi-page, page-aligned memory regions is
>>   inefficient - use alloc_xenheap_pages() instead
>> - albeit an allocation error is unlikely here, add error handling
>>   nevertheless (and have nestedhvm_vcpu_initialise() bail if an error
>>   occurred during setup)
>> - nestedhvm_enabled() must no access d->arch.hvm_domain without first
>>   checking that 'd' actually represents a HVM domain
>> 
>> Signed-off-by: Jan Beulich <JBeulich@xxxxxxxx>
> 
> 
> Looks ok to me. How did you test it?

Sorry, no, I did not test it at all. Should probably have said so...
I just noticed the brokenness while putting together the VIA
enabling patch sent soon afterwards.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel