[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 13/15] libxl: call hotplug scripts for nic devices from libxl

Ian Jackson wrote:
+        !aodev->vif_executed) {
+        aodev->vif_executed = 1;
+        device_hotplug(egc, aodev);
+        return;
+    }

This logic surrounding vif_executed is rather opaque.  Are you trying
to run this whole lot twice so that you can run two lots of scripts ?

If so then perhaps the hotplug helper should simply take a counter, so
that we don't expose this vif abstraction thing ?  And it would be
applicable to everything, not just vifs.

Yes, it's kind of a counter, but first and second calls have different arguments/env. The fact is that from my point of view they should be two different devices (vif and tap), but that will require major changes in libxl.

I could change vif_executed to something like exec_num, but it won't make much sense anyway I think, and we will have to pass it to the hotplug helper the same way we are passing vif_executed.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.