[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 07/15] libxl: convert libxl_domain_destroy to an async op

Roger Pau Monne writes ("Re: [PATCH v2 07/15] libxl: convert 
libxl_domain_destroy to an async op"):
> Ian Jackson wrote:
> [...]
> I will apply the block of changes that I've removed from this reply.
> >> +static void device_remove_callback(libxl__egc *egc, libxl__ao_device 
> >> *aorm)
> > I don't understand why this is here in this patch.  Surely it belongs
> > in the previous one ?
> Not really, because libxl__destroy_devices is called from 
> libxl_domain_destroy, which does not ao until this patch, so this 
> callback is the libxl__devices_destroy one (which was not async in 
> previous patches), since it called libxl__device_destroy instead of 
> libxl__initiate_device_remove.

Oh, yes, of course.  Thanks.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.