[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] libxl: cannot start guest

On 05/22/12 17:21, Ian Campbell wrote:

> On Tue, 2012-05-22 at 16:16 +0100, Christoph Egger wrote:
>> On 05/22/12 16:20, Ian Campbell wrote:
>>> All the >= checks on *xcg_handle seem wrong to me. Really they should be
>>> checking != NULL, since otherwise they don't actually discriminate the
>>> two cases! Does making that change help?
>> Yes, that helps! I can start guests again.
> Excellent, I assume you are going to submit the patch (i.e. I don't need
> to..)

Yes, patch attached.

Fix pointer checks introduced in changeset 24757:aae516b78fce.
This fixes xenstored crash on platforms with no gnttap implementation.

Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Attachment: xen_tools_xenstore.diff
Description: xen_tools_xenstore.diff

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.