Re: [Xen-devel] [PATCH] xen: do not disable netfront in dom0

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 21 May 2012, Ian Campbell wrote:
> On Mon, 2012-05-21 at 16:58 +0100, Stefano Stabellini wrote:
> > On Sun, 20 May 2012, Marek Marczykowski wrote:
> > > Netfront driver can be also useful in dom0, eg when all NICs are assigned 
> > > to
> > > some domU (aka driver domain). Then using netback in domU and netfront in 
> > > dom0
> > > is the only way to get network access in dom0.
> > > 
> > > Signed-off-by: Marek Marczykowski <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> > > ---
> > >  drivers/net/xen-netfront.c |    3 ---
> > >  1 files changed, 0 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> > > index 698b905..e5a161a 100644
> > > --- a/drivers/net/xen-netfront.c
> > > +++ b/drivers/net/xen-netfront.c
> > > @@ -1953,9 +1953,6 @@ static int __init netif_init(void)
> > >   if (!xen_domain())
> > >           return -ENODEV;
> > >  
> > > - if (xen_initial_domain())
> > > -         return 0;
> > > -
> > >   printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n");
> > >  
> > >   return xenbus_register_frontend(&netfront_driver);
> > 
> > you need something similar in netif_exit too
> 
> Do we need this in other *foo*front as well? e.g. block?

nope, xen-blkfront doesn't have any xen_initial_domain checks.
The other frontends with xen_initial_domain checks are:

drivers/input/misc/xen-kbdfront.c
drivers/video/xen-fbfront.c
drivers/pci/xen-pcifront.c

While it makes sense to keep xen-pcifront dom0 only for the moment, it
might be useful to remove the xen_initial_domain checks from xen-fbfront and
xen-kbdfront.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel