Re: [Xen-devel] [PATCH] full support of setting scheduler parameters on domain creation

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-05-21 at 14:48 +0100, George Dunlap wrote:
> On Mon, May 21, 2012 at 2:34 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> >> Hmm. Scheduling parameters are handled in the hypervisor. I don't want to
> >> export the knowledge about semantics to the tools. If this is no problem,
> >> why can't I just set the defaults in the tools and omit asking the
> >> hypervisor for the current settings?
> >
> > Exporting the idea that 0 is not a valid weight is (IMHO at least)
> > better than exporting the fact that the default weight is (e.g.) 200 and
> > hard coding that in multiple places.
> 
> I agree.
> 
> > You could define a symbolic name if that would make you more comfortable
> > (that would allow us to change the specific value without changing the
> > API)
> 
> That is, as long as the "reasonable value" is the same for all of the
> parameters.

I actually meant a symbolic name for the default of each, rather than
one for all of them.

> I half wonder if having an "init schedule params" function which would
> set each value to the default for that value would be useful, or if it
> would be overkill.
> 
> Of course, if we're doing that, it's only one step further to just
> reading the actual scheduler parameters...

I suppose we could make the autogenerated libxl_sched_params_init
instead be a hand-coded thing which actually reads them.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel