[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 06/13] libxl: cleanup libxl__device_{disk, nic}_add

To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 18 May 2012 17:07:46 +0100
Cc: "xen-devel@xxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxx>
Delivery-date: Fri, 18 May 2012 16:08:06 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

Roger Pau Monne writes ("[PATCH 06/13] libxl: cleanup 
libxl__device_{disk,nic}_add"):
> Change libxl__sprintf for GCSPRINTF, LIBXL__LOG* for LOG and remove
> use of ctx variable in favour of the CTX constant.

Is this necessary to make things fit in subsequent patches ?

In general I approve of this kind of cleanup but I don't think now is
the right time to be doing it...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

References:
- [Xen-devel] [PATCH 0/13] execute hotplug scripts from libxl
  - From: Roger Pau Monne
- [Xen-devel] [PATCH 06/13] libxl: cleanup libxl__device_{disk, nic}_add
  - From: Roger Pau Monne

Prev by Date: Re: [Xen-devel] [PATCH 03/13] libxl: add libxl__xs_path_cleanup
Next by Date: Re: [Xen-devel] [PATCH 07/13] libxl: convert libxl_domain_destroy to an AO op
Previous by thread: [Xen-devel] [PATCH 06/13] libxl: cleanup libxl__device_{disk, nic}_add
Next by thread: [Xen-devel] [PATCH 04/13] libxl: move libxl_device_disk_add to libxl_device
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.