Re: [Xen-devel] [PATCH v6 04/11] libxl: move libxl__device_from_disk to libxl_internal.c

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("Re: [Xen-devel] [PATCH v6 04/11] libxl: move 
libxl__device_from_disk to libxl_internal.c"):
> In my hotplug series I'm moving most libxl_device_{...}_add to provide 
> an internal implementation that takes an ao, making something quite 
> similar to what Stefano does, if I start moving all those to 
> libxl_internal we will fill this file with functions that could be 
> somewhere else (libxl_device). I understand that the libxl policy is put 
> functions where they seem to belong (device related functions to 
> libxl_device, domain related ones to libxl_dom...), and if they fit in 
> none of this categories then put them in libxl_internal or create a new 
> file.
> 
> We can leave it in libxl_internal for now, and I will move it on my series.

I don't think we have a policy.  I think at this stage I would much
prefer not to move whole functions from one file to another for purely
cosmetic reasons.

(It's a different question if you need to move the body of a function
into the middle of another one, or something.)

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel