Re: [Xen-devel] [PATCH] libxl: do not overwrite user supplied config when running bootloader

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH] libxl: do not overwrite user 
supplied config when running bootloader"):
> > [...]
> > +    if (!info->u.pv.bootloader) {
> > +        LOG(DEBUG, "no bootloader configured, using user supplied kernel");
> > +        bl->kernel->path = bl->info->u.pv.kernel;
> > +        bl->ramdisk->path = bl->info->u.pv.ramdisk;
> > +        bl->cmdline = bl->info->u.pv.cmdline;
> > +        rc = 0;
> > +        goto out_ok;
> > +    }
> 
> I'm not at all sure about this. Is it valid for an async operation to
> keep references to the parameters from the caller and to use them for
> the duration of the operation? IOW is there a requirement that the
> caller keeps the arguments live until the op completes? It's seems
> obvious that there should but I thought I'd seen a comment to the
> contrary somewhere (which I now can't see, perhaps I was thinking about
> the lack of a requirement to keep the ao_how valid).

Yes, there is such a requirement and it should be documented.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel