Re: [Xen-devel] [PATCH v2] xl: introduce specific VCPU to PCPU mapping in config file

[Dario Faggioli <raistlin@xxxxxxxx>]

On Mon, 2012-05-14 at 10:34 +0100, Ian Campbell wrote:
> On Mon, 2012-05-14 at 10:26 +0100, Dario Faggioli wrote:
> > xm supports the following syntax (in the config file) for
> > specific VCPU to PCPU mapping:
> > 
> > cpus = ["2", "3"] # VCPU0 runs on CPU2, VCPU1 runs on CPU3
> > 
> > Allow for the same in xl.
> > 
> > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> > 
> > ...
> > +
> > +=item "0-3,5,^1"
> > +
> > +To allow all the vcpus of the guest to run on cpus 0,2,3,5.
> > +
> > +=item [2, 3]
> 
> Is this [2, 3] or ["2", "3"] as you used in the commit message? (would
> it be confusing the make those distinct, represent the current xl
> behaviour and xm behaviour respectively?)
> 
Well, tools/examples/xmexample.hvm says xm supports `cpus=["2", "3"]`,
while on xl both syntax (with or without the inner `"`) are recognized
by xlu_get_list[item]().

TBH, I don't think it's worth distinguishing between the two, especially
considering we have the string syntax (i.e., `cpus="2,3") to achieve the
current behaviour.

> I think you missed my review on the v1 code when preparing this posting
> (we probably passed in mid-air)?
> 
Indeed! :-)

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel