[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: fix i8259A_resume()


  • To: Jan Beulich <JBeulich@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxx>
  • From: Keir Fraser <keir.xen@xxxxxxxxx>
  • Date: Mon, 14 May 2012 16:33:02 +0100
  • Delivery-date: Mon, 14 May 2012 15:34:17 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: Ac0x5tk1z5FUXtZqW027kHdEakJUKg==
  • Thread-topic: [Xen-devel] [PATCH] x86: fix i8259A_resume()

On 14/05/2012 12:46, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> On systems that have an IO-APIC, we generally run the PIC in AEOI
> mode, yet i8259A_resume() so far failed to put it back into that mode.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Keir Fraser <keir@xxxxxxx>

> --- a/xen/arch/x86/i8259.c
> +++ b/xen/arch/x86/i8259.c
> @@ -314,7 +314,7 @@ static void save_ELCR(char *trigger)
>  
>  int i8259A_resume(void)
>  {
> -    init_8259A(0);
> +    init_8259A(i8259A_irq_type.ack == disable_8259A_irq);
>      restore_ELCR(irq_trigger);
>      return 0;
>  }
> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.