Re: [Xen-devel] [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release()

[Kevin Wolf <kwolf@xxxxxxxxxx>]

Am 14.05.2012 12:30, schrieb Jan Beulich:
> While for the "normal" case (called from blk_send_response_all())
> decrementing requests_finished is correct, doing so in the parse error
> case is wrong; requests_inflight needs to be decremented instead.
> 
> Change in v2: Adjust coding style.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

I think it would be nicer if a struct ioreq had an explicit state so
that you don't have to pass the right state when releasing it. But
anyway, the patch looks correct to me:

Reviewed-by: Kevin Wolf <kwolf@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel