[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3 of 4 v2] libxl: Introduce pci_assignable_add and pci_assignable_remove

On 14/05/12 10:21, Ian Campbell wrote:
+    if (f == NULL) {
+        LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, "Couldn't open %s",
+                         SYSFS_PCIBACK_DRIVER"/slots");
+        return ERROR_FAIL;
+    }
+    while(fscanf(f, "%x:%x:%x.%x\n",&dom,&bus,&dev,&func)==3) {
Shouldn't this 3 be 4 now that you include dom?
Ah, of course -- this is handling a case that doesn't happen normally when you use the commands (i.e., having a slot in pciback but not being bound), so it didn't get tested. I'll make sure to check that.
Also ISTR some change to the precise formatting using by the kernel for
BDFs recently (A . became a : or vice versa?). CCing Konrad for input in
case it impacts this too.
That would be pretty unfortunate; but it seems like it would also be pretty unlikely, as it would break an awful lot of user-mode programs, yes? Linus seems to have a zero-tolerance policy towards that kind of thing.

I'll fix this up, re-test, and wait for Konrad's comment before re-sending.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.