Re: [Xen-devel] [PATCH 4 of 4 v2] xl: Add pci_assignable_add and remove commands

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-05-11 at 14:31 +0100, George Dunlap wrote:
> pci-assignable-add will always store the driver rebind path, but
> pci-assignable-remove will only actually rebind if asked to do so.
> 
> v2:
>  - Use libxl_device_pci_init() instead of memset()
>  - Call xlu_cfg_destroy() properly
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

(one typo below twice, if you don't end up reposting due to comments on
3/4 I'll fix that up as it goes in)

> +static void pciassignable_add(const char *bdf, int rebind)
> +{
> +    libxl_device_pci pcidev;
> +    XLU_Config *config;
> +
> +    libxl_device_pci_init(&pcidev);
> +    
> +    config = xlu_cfg_init(stderr, "command line");
> +    if (!config) { perror("xlu_cfg_inig"); exit(-1); }

                                      init
[...]
> +static void pciassignable_remove(const char *bdf, int rebind)
> +{
> +    libxl_device_pci pcidev;
> +    XLU_Config *config;
> +
> +    libxl_device_pci_init(&pcidev);
> +
> +    config = xlu_cfg_init(stderr, "command line");
> +    if (!config) { perror("xlu_cfg_inig"); exit(-1); }

And again.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel