Re: [Xen-devel] Errors of doing "make install-tools" with xen-4.2-unstable?

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 11/05/2012 15:16, "Ian Campbell" <Ian.Campbell@xxxxxxxxxx> wrote:

> On Fri, 2012-05-11 at 15:08 +0100, Bei Guan wrote:
> When I do the "make
> install-tools" with xen-4.2-unstable, there are
> some errors about
> "warn_unused_result".
> Is it the error in code or the error in the compiling
> environment?
> Thank you so much.

This commit
        changeset:
> 25275:27d63b9f111a
        user:        Keir Fraser <keir@xxxxxxx>

> date:        Thu May 10 11:22:18 2012 +0100
        summary:     blktap2: Do
> not build with -O0
has caused more warnings to be generated by the compiler,
> which in turn
leads to build failures. Since this is a compiler specific thing
> we are
still tracking them all down.

Can you confirm which versionof
> xen-unstable.hg you are using -- there
have been several fixup patches since
> the above. If you are completely
up to date and you still see errors we can
> dig into whatever is left.

Ian. (starting to think that this change wasn't
> suitable during a
feature freeze....)

The original reason for making this fix now was build failure on Fedora 17,
due to -O0 implying -D_FORTIFY_SOURCE=2, and some kind of fall-out from
that. A simpler feature-freeze fix might be to simply disable -Werror for
subtrees that are using -O0. Since this needs backport for 4.0 and 4.1 as
well. Or perhaps we are nearly at the end of the bug tail. ;-)

 -- Keir

> 
> 
> gcc  -O1 
> -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing
> -std=gnu99 -Wall
> -Wstrict-prototypes -Wdeclaration-after-statement
> -D__XEN_TOOLS__ -MMD -MF
> .tapdisk-queue.o.d  -D_LARGEFILE_SOURCE
> -D_LARGEFILE64_SOURCE
> -fno-optimize-sibling-calls -Werror -g
> -Wno-unused -fno-strict-aliasing
> -I../include -I../drivers
>
> -I/root/Xen/xen-4.2-unstable/tools/blktap2/drivers/../../../tools/libxc
> -I/root/Xen/xen-4.2-unstable/tools/blktap2/drivers/../../../tools/include
> -D_GNU_SOURCE -DUSE_NFS_LOCKS -fPIC -I
> /root/Xen/xen-4.2-unstable/tools/blktap2/drivers/../../../tools/libaio/src  -c
> -o tapdisk-queue.o tapdisk-queue.c 
> cc1: warnings being treated as errors
>
> tapdisk-queue.c: In function ?tapdisk_lio_ack_event¹:
> tapdisk-queue.c:438:
> error: ignoring return value of ?read¹, declared
> with attribute
> warn_unused_result
> make[5]: *** [tapdisk-queue.o] Error 1
> make[5]: Leaving
> directory
> `/root/Xen/xen-4.2-unstable/tools/blktap2/drivers'
> make[4]: ***
> [subdir-install-drivers] Error 2
> make[4]: Leaving directory
> `/root/Xen/xen-4.2-unstable/tools/blktap2'
> make[3]: *** [subdirs-install]
> Error 2
> make[3]: Leaving directory
> `/root/Xen/xen-4.2-unstable/tools/blktap2'
> make[2]: ***
> [subdir-install-blktap2] Error 2
> make[2]: Leaving directory
> `/root/Xen/xen-4.2-unstable/tools'
> make[1]: *** [subdirs-install] Error 2
>
> make[1]: Leaving directory `/root/Xen/xen-4.2-unstable/tools'
> make: ***
> [install-tools] Error 2
> ------
>
> root/Xen/xen-4.2-unstable/tools/blktap2/drivers/../../../tools/libaio/src  -c
> -o tapdisk-log.o tapdisk-log.c 
> cc1: warnings being treated as errors
>
> tapdisk-log.c: In function ?tlog_flush¹:
> tapdisk-log.c:250: error: ignoring
> return value of ?write¹, declared
> with attribute warn_unused_result
>
> ------
> 
> /root/Xen/xen-4.2-unstable/tools/blktap2/drivers/../../../tools/libaio/src  -c
> -o tapdisk2.o tapdisk2.c 
> cc1: warnings being treated as errors
>
> tapdisk2.c: In function ?main¹:
> tapdisk2.c:82: error: ignoring return value
> of ?chdir¹, declared with
> attribute warn_unused_result
> ------
> cc1:
> warnings being treated as errors
> tapdisk-stream.c: In function
> ?tapdisk_stream_poll_clear¹:
> tapdisk-stream.c:148: error: ignoring return
> value of ?read¹, declared
> with attribute warn_unused_result
>
> tapdisk-stream.c: In function ?tapdisk_stream_poll_set¹:
>
> tapdisk-stream.c:158: error: ignoring return value of ?write¹,
> declared with
> attribute warn_unused_result
> tapdisk-stream.c: In function
> ?tapdisk_stream_print_request¹:
> tapdisk-stream.c:206: error: ignoring return
> value of ?write¹,
> declared with attribute warn_unused_result
> 
> 
> 
> Best
> Regards,
> Bei Guan
>
> 



_______________________________________________
Xen-devel mailing
> list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel