[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxc: implement gnttab.set_max_grants for Linux

>>> On 11.05.12 at 10:02, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Fri, 2012-05-11 at 08:23 +0100, Jan Beulich wrote:
>> +        /*
>> +         * Newer (e.g. pv-ops) kernels don't implement this IOCTL,
>> +         * so ignore the resulting specific failure.
>> +         */ 
> pvops doesn't implement this ioctl because it is already more dynamic
> and therefore setting a max unnecessary?
> (I'm pretty sure yes, but just wanted to confirm we shouldn't be fixing
> anything on the pvops side).

Correct. The only adjustment I would consider worth doing is to
accept the unnecessary ioctl without producing an error or logging
any message (perhaps one could in fact return an error for insanely
high input values).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.