Re: [Xen-devel] [PATCH v2] libxl: make libxl_device_{vkb, vfb}_add async operations.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[Xen-devel] [PATCH v2] libxl: make libxl_device_{vkb, 
vfb}_add async operations."):
> Also move the functions to libxl_device.c, as done with disk and nic
> add fuctions, so libxl_device_{vkb,vfb}_add are mere wrappers arround
> libxl__device_{vkb,vfb}_add, that can be called from a running AO
> operation. Quite a lot of code motion here also, and integration with
> the new AO domain creation.
> 
> This should be applied after my "libxl: call hotplug scripts from
> libxl for vif" series.

Can you please (a) add it to the end of your series and (b) separate
out the code motion ?  As it is it is difficult to review.

As a guideline, I would recommend trying to actually read the patch,
by eye, before you post it.  If you find you can't make head or tail
of it then probably we won't be able to either :-).

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel