Re: [Xen-devel] [PATCH v4 2/4] libxl: add libxl__xs_path_cleanup

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[Xen-devel] [PATCH v4 2/4] libxl: add 
libxl__xs_path_cleanup"):
> Add a function which behaves like "xenstore-rm -t", and which will be
> used to
> clean xenstore after unplug since we will be no longer executing
> xen-hotplug-cleanup script, that used to do that for us.

I still think this needs to run in a transaction.

Otherwise, if another xenstore user adds an entry to one of the
directories we think is empty, we will unwittingly remove that entry.

And in general it may be necessary to use the caller's transaction.
So I would make libxl__xs_path_cleanup always require a non-null
transaction to be passed in by the caller.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel