Re: [Xen-devel] [xen-unstable test] 12828: regressions - FAIL

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-05-10 at 14:01 +0100, Ian Campbell wrote:
> On Thu, 2012-05-10 at 12:58 +0100, xen.org wrote:
> > flight 12828 xen-unstable real [real]
> > http://www.chiark.greenend.org.uk/~xensrcts/logs/12828/
> > 
> > Regressions :-(
> > 
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> >  build-i386                    4 xen-build                 fail REGR. vs. 
> > 12827
> 
> gcc  -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 
> -Wall -Wstrict-prototypes -Wdeclaration-after-statement   -D__XEN_TOOLS__ 
> -MMD -MF .img2qcow.o.d  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE 
> -fno-optimize-sibling-calls -Werror -g -Wno-unused -fno-strict-aliasing 
> -I../include -I../drivers 
> -I/home/osstest/build.12828.build-amd64/xen-unstable/tools/blktap2/drivers/../../../tools/libxc
>  
> -I/home/osstest/build.12828.build-amd64/xen-unstable/tools/blktap2/drivers/../../../tools/include
>  -D_GNU_SOURCE -DUSE_NFS_LOCKS -fPIC  -c -o img2qcow.o img2qcow.c 
> gcc  -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 
> -Wall -Wstrict-prototypes -Wdeclaration-after-statement   -D__XEN_TOOLS__ 
> -MMD -MF .qcow2raw.o.d  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE 
> -fno-optimize-sibling-calls -Werror -g -Wno-unused -fno-strict-aliasing 
> -I../include -I../drivers 
> -I/home/osstest/build.12828.build-amd64/xen-unstable/tools/blktap2/drivers/../../../tools/libxc
>  
> -I/home/osstest/build.12828.build-amd64/xen-unstable/tools/blktap2/drivers/../../../tools/include
>  -D_GNU_SOURCE -DUSE_NFS_LOCKS -fPIC  -c -o qcow2raw.o qcow2raw.c 
> cc1: warnings being treated as errors
> block-remus.c: In function 'ramdisk_flush':
> block-remus.c:508: error: 'buf' may be used uninitialized in this function
> make[5]: *** [block-remus.o] Error 1
> make[5]: *** Waiting for unfinished jobs....
> 
> I presume this is 25289:27d63b9f111a "blktap2: Do not build with -O0" or
> one of the followup patches?
> 
> Ah:
> 
> > version targeted for testing:
> >  xen                  27d63b9f111a
> 
> So before all the fixups -- I suppose this will pass on the next run.

Keir says this isn't one he has fixed. I can't repro it either (and I
run Squeeze, just like the build system) but by inspection this ought to
solve it.

8<--------------------------------------

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1336655664 -3600
# Node ID 6d45fbdca09be60726eb7043a42dbac552e202e0
# Parent  bc8630bc68025bdee747ebe707b764e323914fd6
blktap2/remus: initialise variable.

gcc seems to not be able to spot that it is always initialised, based on the
complexity of merge_requests' error handling I don't blame it.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r bc8630bc6802 -r 6d45fbdca09b tools/blktap2/drivers/block-remus.c
--- a/tools/blktap2/drivers/block-remus.c       Thu May 10 14:07:31 2012 +0100
+++ b/tools/blktap2/drivers/block-remus.c       Thu May 10 14:14:24 2012 +0100
@@ -533,6 +533,7 @@ static int ramdisk_flush(td_driver_t *dr
                        i++;
                batchlen = sectors[i-1] - base + 1;
 
+               buf = NULL;
                j = merge_requests(&s->ramdisk, base, batchlen, &buf);
                        
                if (j) {




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel