[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: Fix incorrect return of OSEVENT_HOOK macro

On 05/09/2012 09:20 AM, Ian Jackson wrote:
> Daniel De Graaf writes ("[PATCH] libxl: Fix incorrect return of OSEVENT_HOOK 
> macro"):
>> The OSEVENT_HOOK_INTERN macro incorrectly returned the value of the
>> expression CTX->osevent_in_hook-- (usually 1) instead of the value of
>> the function call it made. Change the macro to a statement including the
>> return variable to fix this.
> Also, does this mean that you're using this in anger, or did you just
> happen to spot it while perusing the code ?
> Thanks,
> Ian.

I am using this functionality in a locally-patched libvirt where I have
replaced libxl 4.1 support with 4.2. I don't think the changes I made are
suitable for upstream as I assume libvirt will want to continue to support
libxl 4.1 in addition to 4.2 (and my patch discards the 4.1 support).

Daniel De Graaf
National Security Agency

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.