[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: Fix incorrect return of OSEVENT_HOOK macro

Daniel De Graaf writes ("[PATCH] libxl: Fix incorrect return of OSEVENT_HOOK 
> The OSEVENT_HOOK_INTERN macro incorrectly returned the value of the
> expression CTX->osevent_in_hook-- (usually 1) instead of the value of
> the function call it made. Change the macro to a statement including the
> return variable to fix this.

Well spotted, thanks.  But I think it would be better to use the GCC
statement expression syntax to avoid changing the call sites ?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.