Re: [Xen-devel] [PATCH 0 of 6] Add vncviewer xm compatibility options

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-05-07 at 02:20 +0100, Goncalo Gomes wrote:
> The following series of patches introduce vncviewer compatibility 
> options to the create and restore commands.

I have a look through and it generally looks good, I made some comments
on specific patches as I went.

One overall comment is that, while we generally prefer that a series is
broken down into "one feature per patch", I think you've gone a little
too far here. The docs updates, parser updates and the implementation
can all reasonably come together in the same patch.

The only thing which could be separate is "[...4 of 6] xl: move
vncviewer function closer to the start of file so it can be seen by
create_domain" which it would be useful to have as an early patch in the
series (since splitting pure code motion out is always useful).

Cheers,
Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel