Re: [Xen-devel] [PATCH 3 of 6] libxl: add vncviewer boolean options

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-05-07 at 02:20 +0100, Goncalo Gomes wrote:
> Signed-off-by: Goncalo Gomes <Goncalo.Gomes@xxxxxxxxxxxxx>
> 
> diff -r 79526068a874 -r 497a6061df08 tools/libxl/libxl_create.c
> --- a/tools/libxl/libxl_create.c      Mon May 07 01:10:58 2012 +0000
> +++ b/tools/libxl/libxl_create.c      Mon May 07 01:10:58 2012 +0000
> @@ -156,6 +156,7 @@ int libxl__domain_build_info_setdefault(
>      if (b_info->target_memkb == LIBXL_MEMKB_DEFAULT)
>          b_info->target_memkb = b_info->max_memkb;
>  
> +    libxl_defbool_setdefault(&b_info->vncviewer, false);
>      libxl_defbool_setdefault(&b_info->localtime, false);
>  
>      libxl_defbool_setdefault(&b_info->disable_migrate, false);
> diff -r 79526068a874 -r 497a6061df08 tools/libxl/libxl_types.idl
> --- a/tools/libxl/libxl_types.idl     Mon May 07 01:10:58 2012 +0000
> +++ b/tools/libxl/libxl_types.idl     Mon May 07 01:10:58 2012 +0000
> @@ -250,6 +250,7 @@ libxl_domain_build_info = Struct("domain
>      ("video_memkb",     MemKB),
>      ("shadow_memkb",    MemKB),
>      ("rtc_timeoffset",  uint32),
> +    ("vncviewer",       libxl_defbool),

libxl never does anything with this, other that set the default as
above.

Does this value need to be in the libxl API, could it not be entirely an
xl thing, as part of the struct domain_create?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel